On Fri, Dec 11, 2009 at 04:40:45PM -0600, Shawn Walker wrote:
> [email protected] wrote:
> >On Fri, Dec 11, 2009 at 02:17:32PM -0800, Brock Pytlik wrote:
> >>[email protected] wrote:
> >>>Folks,
> >>>The following webrev implements API support for canceling a search
> >>>operation.  The GUI will make use of this functionality.  A webrev is
> >>>available from the location below:
> >>>
> >>>   http://cr.opensolaris.org/~johansen/webrev-8584/
> >>>
> >>>Thanks,
> >>>
> >>>-j
> >>>
> >>>_______________________________________________
> >>>pkg-discuss mailing list
> >>>[email protected]
> >>>http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
> >>api.py:
> >>543: should the history of a canceled operation be recorded?
> >
> >I thought the answer was no, since this code looked like it was only
> >interested in recording errors, and cancellation didn't appear to be
> >recorded before.  Have I misunderstood what was previously recorded?
> 
> In the past, errors have been recorded when a client has cancelled
> an operation, at least via KeyboardInterrupt.
> 
> The reasoning was that if the user cancelled an install or update,
> that was important enough to record (especially if it was during
> plan execution) when attempting to debug resulting fallout later.

Ok, my mistake.  I will change this to record the cancellation.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to