Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-license-2/
Bug 13156 doesn't appear to be part of this changeset.
license.py:
- line 48: I don't think anything uses the attributes class member
anymore.
- line 177:
return self.attrs.get("must-accept", "").lower() == "true"
api_errors.py:
- line 76: why not just use **kwargs?
- line 110-112: why not combine?
self._errors.setdefault(str(e.fmri), []).append(e)
imageplan.py:
- line 670: what does this have to do with the license stuff?
- line 696: what does this look like on screen? Do we get two different
lines of progress tracking?
- line 804: excessive indent
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
