On 01/15/10 01:48 PM, Tim Foster wrote:
On Fri, 2010-01-15 at 13:05 +0000, Michal Pryc wrote:
Should you preserve and then restore os.environ? Similar to lines 462/471?
I'm not sure there's any need - we're running a command which gets
passed a new copy of os.environ and doesn't get to touch the original,
so there should be no need to restore it, unless I'm missing something?
I agree with that, but it's better to understand everything.
One formatting nit, that can be fixed:
In the original code on line 631, there was:
cwd = swdir
You have changed that to line 645, but the spaces around "=" can be removed.
No problem, made that change - thanks for taking a look :-) The webrev
is updated at:
http://cr.opensolaris.org/~timf/13799-webrev
Yep, that looks perfect.
--
Michal Pryc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
