On 05/14/10 01:19 PM, [email protected] wrote:
On Thu, May 13, 2010 at 06:39:28PM -0500, Shawn Walker wrote:
webrev:
   http://cr.opensolaris.org/~swalker/pkg-15328/

modules/server/depot.py:

   - line 260: One value is 30 minutes, and the other is 15 minutes?  Was
     that intentional?

Yes, and I believe we discussed this originally, but see below.

     Despite discussing this before, I'm still nervous about caching this
     value.  We don't know when the server might get updgraded, or change
     it's operating mode.  If it's really necessary to cache this, will
     you set the time to 1-5 minutes instead?  If we decide that this is
     too short, we can always change it back later.  (And you can say, "I
     told you so.")

Yes, that's fine. It's trivial enough to change if we have regrets later. I'll set it to 5 minutes instead (for both values).

General Question:

   - I think it would really help if we added a flag, image-property, or
     environment variable to the client that allows it to override the
     caching directives supplied by the depot.  If the user-agent
     includes "Pragma: no-cache" and "Cache-Control: no-cache" in its
     header, this tells the caches in the chain to revalidate their
     requests, and ensures that a cached copy is not used.  I think this
     would be really helpful in any situation where we have to debug a
     problem with a flaky cache. This might allow users plagued by a
     misbehaving cache to work around the problem.  Would you be able to add
     something like this to the client?  If you don't have time to do
     this, would you at least file a transport bug for this support?

I'll open an RFE for transport.

Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to