On 05/20/10 09:43, Padraig O'Briain wrote:
On 05/20/10 08:20, Padraig O'Briain wrote:
On 05/19/10 16:39, Joanmarie Diggs wrote:
Hey Padraig.

I have spun another webrev, http://cr.opensolaris.org/~padraig/ips-13978-v2/.

I love it. Thanks again!

(Missed a nit before: Both Clear and Close are set to Alt+C. They should
probably be unique. Sorry!! But other than that it's awesome as far as
I'm concerned.)


I am not sure that I can do anything about this.

I am using the GTK stock button for Clear. For some languages it has the same mnemonic as Close. In my short test Clear and Close have the same mnemonic in English and Chinese but do not for French, German, Brazilian Portuguese.

If I do not use a standard stock button the mnemonic will be unexpected in some languages.

Padraig
--joanie



I have spun another webrev, http://cr.opensolaris.org/~padraig/ips-13978-v3/. This fixes the problem that messages were no longer logged after clearing the logs.

Padraig

I have spun another webrev, http://cr.opensolaris.org/~padraig/ips-13978-v4/, to change setup_logging to not require client name.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to