On 05/27/10 04:17 PM, [email protected] wrote:
Folks,
The following code review adds support for UNIX domain sockets as a
transport option for both the client and depot. This is needed by
Zones, in order to support a protected local -> global zone transport.
The webrev is here:
http://cr.opensolaris.org/~johansen/webrev-10924/
General:
Does packagemanager choke if a system repo is configured? I'm
obviously not expecting any changes to allow it to configure
one. Specifically, if you try to remove the origin that belongs
to the system repo, etc. ?
src/modules/client/api.py:
line 63: please bump the API version here, and add version 38
to the list on line 129; also update doc/client_api_versions.txt
with a brief summary of client api changes and update all of
the places where API_VERSION is set for a variable
src/modules/client/api_errors.py:
lines 1309, 1317: nit: s/repo/repository/
src/modules/client/publisher.py:
lines 417-419: nit: continuation indent is 4 spaces
src/modules/depotcontroller.py:
line 236: nit: stray newline?
Otherwise, seems reasonable.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
