On 06/ 7/10 03:59 PM, Danek Duvall wrote:
I've a wad for pkgmogrify to take care of the following:
14052 pkgmogrify: extended output capabilities could simplify complex
publication makefiles
16022 pkgmogrify should be able to reference package attributes
16024 pkgmogrify abort operation isn't particularly useful
The webrev is at
http://cr.opensolaris.org/~dduvall/pkg-pkgmog/
src/man/pkgmogrify.1.txt:
lines 118-155: nit: Are these in a specific order intentionally? If
not, I think it'd be more pleasing to the eye and easier to
reference if they were listed in asciiebtical order.
lines 177-183: so users will have to take care to always use sep, etc.
just in case multi-valued attribute values contain spaces?
lines 210ff: I wonder if it's worth mentioning that leading '/' on
paths are ignored so I'm assuming transforms don't have to worry
about leading vs. no leading '/' ?
src/tests/cli/t_pkgmogrify.py:
lines 76-110: Does transformation work on an action with unicode?
line 200: s/specifeid/specified/
src/util/publish/pkgmogrify.py:
line 315: duplicate of line 314?
line 340: action.hash is only valid for file, license, signature.
should this use the roughly the same logic as action.key, others
to handle notfound?
line 378: if it's always "pkg", why not make this a class atribute
instead? I think it will override the inherited one.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
