On 06/ 1/10 11:30 AM, Chris Quenelle wrote:
June 1 update:

https://defect.opensolaris.org/bz/show_bug.cgi?id=15623

I made some updates to the Solaris Studio packages to fix some
bugs and add new licensing files required by legal.

complete webrev: http://cr.opensolaris.org/~quenelle/webrev.15623/


src/util/distro-import/unbundleds/Studio:
  lines 76-81, 102-112, 396-403: if we don't need it; remove it or
      don't add it instead of commenting it.

  line 203: what's this info.keyword thing for?  I'm not aware of any
      of our clients using it.

  line 226: This summary could be a bit more explanatory or detailed.
      The current one assumes forknowledge of what Solaris normally
      delivers, but doesn't really tell me why I would want this
      package.

  line 326-331: Why are these delivered in their own package?  To ensure
      only a single set is delivered?  Some other reason?

  line 364: This summary doesn't match the generic one we seem to use
      for other incorporations.  I'm not saying the current ones are
      preferred, but it would be nice to decide on something consistent.

Someone else should review this too.

Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to