Rainer Orth wrote: > > http://cr.opensolaris.org/~dduvall/pkg-nativepkg/ > > Not a review, just a couple of observations from trying the code: > > * The clean and clobber rules in src/Makefile still referred to pkgdefs > instead of pkg. > > * The clobber rule in src/pkg/Makefile failed to remove Makefile.link. > > * Some rules creating files in src/pkg/$(PDIR) lacked dependencies on > $(PDIR), so the directory might not be present when trying to create > files in it. > > Fixed as below.
Thanks. I've dropped the dependency on $(PDIR) in the %.pub rule, since it already depends on the $(PDIR)/%.mog rule being satisfied, which does have the dependency on $(PDIR). The clobber rule didn't remove Makefile.link because then an immediately following clobber would spend a bunch of time to rebuild Makefile.link just to remove it again. I decided to just pull out all the SVr4-related bits into their own makefile, and use that when building the SVr4 packages, so Makefile.link only gets built when you're doing SVr4 work. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
