This looks good to me.

Padraig

On 08/24/10 02:17 PM, John Rice wrote:
 Thanks Padraig - new webrev which addresses your issues below.

http://cr.opensolaris.org/~jmr/um_6084_simplify_24Aug_215pm/
6084 Simplify Update Manager use same code as PM
16790 InstallUpdate __init__ function should be changed
16880 Install dialog does not update properly when installing packages

JR

On 08/24/10 10:49 AM, Padraig O Briain wrote:
 I believe that this webrev also fixes
16790 InstallUpdate __init__ function should be changed
16880 Install dialog does not update properly when installing packages

The Copyright statement in misc_non_gui.py and update-refresh.sh needs to be updated.
Done

Should the debug option be removed from updatemanger.py and the man page.
Debug is being left in here as running with the --checkupdates-all requires debug option to see any output

When Update Confirmation dialog is displayed the window title for the Update Manager window is still Preparing...". Is this correct?
Nope - this is fixed now and we revert to Update Manager in the title, both here and on completion.

Padraig

On 08/23/10 04:25 PM, John Rice wrote:
Hi - this webrev simplifies check for updates and UM, bringing them together into one module which reuses the PM code in installupdate.py

http://cr.opensolaris.org/~jmr/um_6084_simplify_23Aug_1155am/
6084 Simplify Update Manager use same code as PM

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to