On Wed, 2010-08-25 at 10:51 -0700, [email protected] wrote:
> On Wed, Aug 25, 2010 at 02:18:48PM +1200, Tim Foster wrote:
> > Hi All,
> >
> > I'd appreciate a code review for this fix which breaks up the pkg usage
> > message so that "--help" with a single subcommand only prints usage for
> > that subcommand.
> >
> > This change also prints the subcommand usage whenever we get an invalid
> > option for a valid subcommand, rather than telling us to consult the
> > full usage message.
> >
> > http://cr.opensolaris.org/~timf/12723-usage-webrev
>
> I'm fine with this change.
Thanks for taking a look. Once I've got the pkglint put back, I'll add
the extra bit of unit testing I mentioned and push this.
Rich Lowe has also looked at this change, finding a mistake where a
potential internal error would being logged as a normal error(..) rather
than raising an exception. He also spotted a superfluous '+',
introduced by me or possibly webrev - either way, it was harmless. Both
are fixed now.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
