Shawn Walker wrote: > http://cr.opensolaris.org/~swalker/pkg-17084/
On second pass, it looks fine. On first pass, I thought you were going to end up sometimes trying to rename the temporary file across filesystems, which obviously doesn't work. But that raises the question of why, when it's merely trying to verify formatting, pkgfmt has to write to a file, close it, and read it in again. That seems horribly wasteful. A simple fix would be to use a cStringIO object in that case, but fmt_file() could simply take out_file=None and always return a string buffer or list of lines, or let the caller do the writing ... up to you whether you want to tackle any of it, as it's purely code cleanup and has nothing to do with correctness. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
