It turns out that because the way we do locale facets (i.e.,
"facet.locale.<locale-name>") and that some locales have underscores in
them ("pt_BR", "zh_CN", etc), then we get nastygrams from pkglint.  The
userland gate chose to mark these with "pkg.linted=true", but that's
overkill, and even with 17777 fixed, probably the wrong answer.  Instead, I
propose

    --- a/src/modules/lint/pkglint_action.py
    +++ b/src/modules/lint/pkglint_action.py
    @@ -536,7 +536,8 @@ class PkgActionChecker(base.ActionChecke
                                     if key in ["original_name", "refresh_fmri",
                                         "restart_fmri", "suspend_fmri",
                                         "disable_fmri", "clone_perms",
    -                                    "reboot_needed"]:
    +                                    "reboot_needed"] or \
    +                                        key.startswith("facet.locale."):
                                             continue
                                     engine.warning(
                                         _("underscore in attribute name 
%(key)s in "

as a fix for

    17918 pkglint underscore check should white-list locale facets

THanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to