On 02/18/11 06:15 PM, Bart Smaalders wrote:
A Friday featurette for Danek - compare a manifest w/
saved, merged version.
http://cr.opensolaris.org/~barts/17917/
17917 pkgdiff should be able to compare only one variant
src/man/pkgdiff.1.txt:
line 8: don't we put the ... inside the [] ? looks like
the ... is needed for -v too
line 8: s/ file1/ file1/
line 42: I'd also add that "Each variant may only be specified once."
or "Only one variant value is allowed."
lines 34, 42: I've taken to adding this sentence for options like
this: "This option may be specified multiple times."
src/util/publish/pkgdiff.py:
line 47: don't forget to update once you change man page per above
line 93: s/filtered "/filtered."/
line 107: where is pathname defined? I think that's why they had
separate exception handlers before
line 117: need to use named expandos here (e.g. %(manifest)s)
line 126: s/:/: /
line 128: I assume that you're aware that by doing m[...] the existing
set name=variant.arch value=.... will have it's value updated and
if that set action didn't exist already, it will be added to the
manifest?
Optional unit test could also be added of course :-)
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
