Shawn Walker wrote:

> On 02/25/11 12:51 PM, Danek Duvall wrote:
> >I've updated the webrev:
> >
> >     http://cr.opensolaris.org/~dduvall/pkg-conflict-uninstall-2/
> 
> src/modules/client/imageplan.py:
>   line 812: perhaps have the same comment here as line 784?

They're identical bits of code; I should probably pull that loop out into
its own function.

>   line 837: does this mean that if you were to install and uninstall
>     in the same operation and you ended up with the same problems as you
>     had before, it would allow it?  I don't suppose that's a corner case
>     that we really care about 8-)

Yes.  The intent is to prevent from increasing the number of conflicts in
the image.  Accounting for additions separately from removals is probably
not worthwhile.

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to