OK,
Looks good to me.
Padraig
On 03/16/11 10:08 AM, John Rice wrote:
On 16/03/2011 08:58, Padraig O Briain wrote:
What is the purpose of the print statement at line 489 of
webinstall.py? Is it related to this bug?
I noticed this on review of the bug, as we are doing a sys.exit(1)
immediately the gui is of no use to the user to see the error, hence
the need for a print out. So part of cleanup of WebInstall error
handling.
At line 168-169 of webinstall.py and line 1899 of repository.py do
you need to check whether repo.origins[0].uri is not None?
Nope as: if len(repo.origins) > 0 then we have a properly constructed
origin (RepositoryURI) and cannot have a uri == None (it would raise
an api_errors.BadRepositoryURI on init).
JR
Padraig
On 03/15/11 03:09 PM, John Rice wrote:
Hi - here's a webrev to fix WebInstall's error handling of p5i files
with Publishers that do not have an origin specified and are not on
the system.
http://cr.opensolaris.org/~jmr/pm_17196_webinstall_pub_no_origins_mar15_3pm
17196 webinstall does not handle p5i file without origins
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
