On 03/20/11 01:26 PM, Danek Duvall wrote:
Just for my own understanding, overlay is entirely a debug/testing attribute?http://cr.opensolaris.org/~dduvall/pkg-conflict-preserve/is a fix for 17958 when fixing duplicate action conflicts after uninstall, pkg should leave editable files alone which is the bug that several people ran into when, upon discovering that slim_cd was installed on their system, and conflicting in several files with SUNWcs, removed slim_cd only to find they couldn't log in again. The change in file.py regarding overlays is a separate fix whereby an overlay for a file that was also marked preserve=true didn't actually overwrite the existing file. And there's a handful of cleanup in the tests, because I found myself adding a third (or fourth) copy of the file_* functions. and figured it'd be good to get them all in one place. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
The other thing that confused me a bit was on line 390 in file.py, why is renameold.update treated differently than renameold or renamenew?
I like the consolidation you did in the test suite, thanks for that. Other than my confusion above, it lgtm. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
