On 03/20/11 08:18 PM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-17289/
client.py:
- line 3319: I know this won't be problematic here, but I think you
should add the colon to the end of scheme before testing it against
origin_uri, or you could get false positives. Similar code exists in
imageconfig.py.
Shouldn't technically be possible in either case since the URIs have
been parsed by misc.parse_uri() which would have turned them into proper
URIs with a scheme and everything, but it doesn't hurt either.
Same goes for imageconfig, where unless they've been editing the file by
hand (which will break horribly anyway if they didn't use proper URIs)
it shouldn't be an issue either.
However, I've changed it.
t_pkg_publisher.py:
- line 166, 190: leftover debugging?
No, it's actually to check that the publisher subcommand succeeds even
if the file's been removed. I've clarified each comment.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
