On 03/23/11 09:11 PM, Tim Foster wrote:
Hi there,

I've a short webrev here that I'd appreciate a code review of please:

http://cr.opensolaris.org/~timf/smf-depend-tweak-webrev/

src/modules/flavor/smf_manifest.py:
  Won't these changes mean that manifests using the old attribute name
  won't get dependencies generated?  Was that intentional?  Will there
  be a flag day sent out?

src/tests/api/t_dependencies.py:
  line 689: s/true/true./

  line 1989: extra newline

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to