On Thu, May 05, 2011 at 04:18:20PM -0700, Shawn Walker wrote: > On 03/24/11 01:04 PM, Shawn Walker wrote: > >Greetings, > > > >The following webrev contains changes for the following RFE: > > > >18076 pkg.config integer properties should allow specifying a min and > >max > > > >webrev: > >http://cr.opensolaris.org/~swalker/pkg-18076/ > > Reviews appreciated :-) >
src/modules/config.py - in InvalidPropertyValueError, if there are minimum and maximum values i'm assuming we're dealing with integers here, so i'm a little surprised you're using %s as the format character for printing out minimum, maximum, and value. (perhaps in python it doesn't matter as much as in c?) - in InvalidPropertyValueError, how about an assert verifying that if minimum or maximum are specified then they are integers (along with value). - in InvalidPropertyValueError, how about an assert verifying that both minimum and maximum aren't specified at the same time. otherwise lgtm. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
