Assuming Ed also gave a +1, that makes 3 +1's, no -1's and a week has passed. Do I need to do anything now, or is this friendly nag enough?
Mike On Thu 26 May 2011 at 02:57PM, Edward Pilatowicz wrote: > hey all, > > could mike get push privs for the package repository? > > ed > > ----- Forwarded message from Mike Gerdts <[email protected]> ----- > > Date: Wed, 25 May 2011 15:53:37 -0500 > From: Mike Gerdts <[email protected]> > To: Edward Pilatowicz <[email protected]> > Cc: [email protected] > Subject: Re: Small code review: 18411 zoneadm attach should sanity check args > earlier > > On Wed 25 May 2011 at 01:35PM, Edward Pilatowicz wrote: > > On Wed, May 25, 2011 at 03:25:16PM -0500, Mike Gerdts wrote: > > > Can I get a quick review of this? > > > > > > http://jurassic.us.oracle.com/~mg242268/18411/ > > > > > > 18411 zoneadm attach should sanity check args earlier > > > http://defect.opensolaris.org/bz/show_bug.cgi?id=18411 > > > > > > While it came about due to looking into issues with: > > > > > > 7046131 attaching a zone with multiple BEs fails with confusing error > > > message > > > > > > They really are two separate issues and can be fixed indepedently. > > > > > > > lgtm > > ed > > Excellent. Now we get into deciding what a trivial change is to know > whether I should be asking for commit access now or not. With > assistance, I have done three putbacks to the pkg gate, but the first > one was: > > - exit $ZONE_SUBPROC_INCOMPLETE > + exit $ZONE_SUBPROC_NOTCOMPLETE > > Does my second one (revised dataset layout, 1179 lines) make up for > that? If not, can I get you to push: > > http://jurassic.us.oracle.com/~mg242268/18411.git > > -- > Mike Gerdts > Solaris Core OS / Zones > > ----- End forwarded message ----- -- Mike Gerdts Solaris Core OS / Zones _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
