On Fri, Jun 10, 2011 at 12:13:11AM -0700, Brock Pytlik wrote: > 1) If pkg unfreeze <blah> doesn't match any frozen packages, no > error is reported. I decided that seems reasonable since pkg > unfreeze details each package that was unfrozen, so no output means > no packages were unfrozen.
Not that you care what I think, but this seems inconsisent with the way that most UNIX command line utilities work. Generally, if a command returns no output, the user assumes that the operation has succeeded. I would either return no output if the command succeeds, and print the packages that it failed to unfreeze, or print output for both the success and failure cases. (My own preference is for the former). Also, what's the return code from pkg(1) if the unfreeze doesn't match any packages? If you return 0, you're saying this operation succeeded, even though nothing was matched, which would be hard to script against. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
