On Wed, Jun 29, 2011 at 04:01:32PM -0700, Tim Foster wrote:
> Hi all,
>
> I've a small code review here that fixes a few bugs/rfes with the system
> repository that I'd appreciate a code review of please:
>
> http://jurassic/~timf/sysrepo-errors-webrev
>
> 18272 pkg.sysrepo can't proxy publishers that are redirected
> 18430 system repo chain should be checking uris for file:, not file://
> 18501 pkg.sysrepo errors making incorrect assumptions about missing file repos
> 18524 sysrepo should proxy publishers with no origins
> 18535 sysrepo should have a RewriteRule for OPTIONS requests
> 18611 sysrepo should allow users to add mirrors to syspub-provided publishers
>
> There's only an internal webrev of this at the moment until
> cr.opensolaris.org comes back. I'll send another mail when I've got
> that, but in the meantime if anyone outside the firewall wants to see
> this webrev, drop me a mail and I'll it to you.
>
i don't understand the mako stuff, so hopefully someone else does.
more comments below.
ed
general
- why are we allowing callers to set http_timeout? i'm wary of all the
tunables we're exposing via smf. i realize we haven't commited to
stability for these interfaces, so i guess we can change them at will,
but do we really exepct folks to tune this stuff themselves? (and if
so, won't they be angry when we come along and decide we know better
and remove or change tunables?)
src/sysrepo.py:
- in _follow_redirects() how about:
if not uri.startswith("http:"):
ret_uris.update([uri])
continue
- perhaps you could update the new message to say "file repository %s
does not exist or is not accessible."
- why:
http_timeout = http_timeout
src/tests/cli/t_sysrepo.py
- rather than having each test re-create the image other tests expect at
the end of the test (which can cause cascading failures if some test
dies in the middle), why not have each test create the image it needs
when it starts?
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
