Ed,
Thanks for the quick review.
I've made the validate path change you suggested and added:
safe_dir "$ZONEPATH/lu/system"
safe_dir "$ZONEPATH/lu/system/volatile"
I'll send out a proposal on the default zones sysconfig profile soon.
Thanks,
Susan
On 06/29/11 10:41 AM, Susan Kamm-Worrell wrote:
On 06/28/11 06:00 PM, Edward Pilatowicz wrote:
On Tue, Jun 28, 2011 at 01:27:03PM -0600, Susan Kamm-Worrell wrote:
The code review the ipkg fixes for these bugs:
18553<http://defect.opensolaris.org/bz/show_bug.cgi?id=18553>
zoneadm clone doesn't take full path for sc_profile.xml
18554<http://defect.opensolaris.org/bz/show_bug.cgi?id=18554>
zoneadm clone brand options should precede source zone
18567<http://defect.opensolaris.org/bz/show_bug.cgi?id=18567>
zoneadm clone with no profile should cause SCI tool to be started
http://jurassic.us.oracle.com/net/coupe/builds/sw83825/ips-bugfix/webrev.1
well, d.o.o seems to be down, so i can 't read the bugids.
src/brand/clone:
- lgtm
src/brand/common.ksh:
- before doing:
rm -rf $ZONEPATH//lu/system/volatile
you need to validate each path component using safe_dir()
but 18567 seems to be at odds with what we discussed earlier about a
zone that has no profile specified. in that case we want to default the
zone host name to the zonename and enable dhcp. if we do that we don't
need to run SCI, right? (the zone just works out of the box.)
I'm planning to handle the hostname/dhcp as a separate bugfix.
I'll discuss this in greater detail at the zone iteam today.
Susan
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
