On 07/ 6/11 03:16 PM, Tim Foster wrote:
Hi all,
I've a short code review here that adds support to pkglint to have it
run action validate() methods, and deal with file 'overlay' attributes.
18397 pkglint needs to cope with 'overlay' attributes on files
18627 pgklint should run action validate methods
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-overlay-validate/pkglint-overlay-validate-webrev/
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Hey Tim, in general this LGTM.
One question I did have was about the handling of variants. I'm not
totally sure what the intended rules are here, but my guess would be
(looking around line 633 or pkglint_action or so) that actions with the
same overlay can't intersect under any variants. It's not clear to me
that that's what's actually being tested here. I think only equality
testing is being checked here, so if one action was delivered under
arch=x86, and another was delivered under arch=x86 and arch=sparc (or
had no variants set on it at all) I don't think the check on line would
correctly catch that there should be an error reported. I'm probably
just not following something, but I'm wondering why the
conflicting_variants function wasn't used here?
Thanks
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
