On 07/12/11 15:31, Shawn Walker wrote:
On 07/08/11 21:28, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/ips-18653-v1
Bug:
18653 conditional deps and uninstall: two great tastes that don't taste
great together?
src/modules/client/pkg_solver.py:
So it looks like the only real change was lines 1286-1287?
Yep, the rest were just formating issues that bugged me enough to fix
while trying to debug the problem.
Looks like this turned out to be a far simpler fix than any of us
anticipated. Neat!
I also asked Bart about these changes and he seemed to think they
looked right; was surprised it ever worked right without your fix.
Cool.
src/tests/cli/t_pkg_install.py:
So some cases that seems to be missing from this test:
# Uninstall should fail because pkg7 conditional dependency
# requires pkg6.
self.pkg("install incorp-18653")
self.pkg("uninstall pkg6", exit=1)
# Uninstall should succeed because nothing requires pkg2 even though
# it's involved in a conditional relationship.
self.pkg("install incorp-18653")
self.pkg("uninstall pkg2")
Sure, I can add those tests. Thanks for taking a look.
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
