Shawn Walker wrote:
> https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-validate-1/webrev/
depend.py:
- line 100: why keep a check for "type", but not for "fmri"?
generic.py:
- line 201: why this change? The get() call is slower than the exception
block setup?
- line 706: "returnsa" -> "returns a"
- line 1121: why highlight these four attributes instead of requiring
callers to add them as needed? Ditto on line 1126.
link.py:
- line 63-66: meh. There's nothing wrong with creating such a beast,
just like there's nothing wrong with creating dangling symlinks; we
simply shouldn't die when trying to traverse it. And I don't think I
saw any code that would prevent that.
- line 150: should _validate() simply take a required_attrs parameter?
- line 182, et al: why not "elif mediator is not None", since you already
pulled it out of the dictionary on line 171?
signature.py:
- line 478: What about this code matches the comment? Or is the comment
just a warning of some sort?
- line 481: 'if "value" not in self.attrs'?
dependencies.py:
- line 1352: why treat this as a keyword arg?
publish.py:
- line 817: bad indent?
t_pkgsend.py:
- line 118: what's wrong with this manifest?
actionbench.py:
- line 210: why "pass" here when you did a sys.exit(0) in all the other
cases?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
