On 07/27/11 10:07, Danek Duvall wrote:
Shawn Walker wrote:
...
src/modules/client/api.py:
line 2660: minor nit, but can you put 'collect_attrs' after 'cats'?
these are all keyword arguments and this is an incompatible change
anyway. (Update the docstring too; thanks!)
Sure. Is this just to maintain alphabetical order (I hadn't even noticed
they were sorted that way)?
Yes; in general, I've tried to keep parameter lists in alphabetical
order since it seems to make readability a bit better. I haven't always
been successful.
There are warnings in the documentation about always using keyword
arguments as keywords and not positionally.
Thanks!
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
