On Sat, Aug 13, 2011 at 11:44:18AM -0700, Danek Duvall wrote:
> Shawn Walker wrote:
>
> > On 08/12/11 19:38, Edward Pilatowicz wrote:
> > >i've got a fix to remove the pkg linked image subcommands from the
> > >default pkg usage message. the bug is:
> > >
> > >18816 pkg usage should not mention linked image commands
> > >https://defect.opensolaris.org/bz/show_bug.cgi?id=18816
> > >
> > >the webrev is:
> > >
> > >http://mcescher.us.oracle.com/export/ws/pkg-noliusage/webrev/
> > >
> > >the fix is also inline below.
> >
> > If I understand your changes here correctly, this makes it so that
> > these commands don't show up in the default usage, but if you
> > specifically type one of them, you see the options and you can get
> > help on them.
yep.
>
> That seems like reasonable behavior to me, though if there were some way to
> stick in a notice that this was a private implementation detail in the
> usage/help output, that would be nice, too.
>
how about i add:
if not full and cmd:
- logger.error("Usage:")
+ if cmd not in priv_usage:
+ logger.error(_("Usage:"))
+ else:
+ logger.error(_("Private subcommand usage, options "
+ "subject to change at any time:"))
combined = {}
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
