On 08/18/11 15:20, Shawn Walker wrote:
On 08/15/11 18:44, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/17988-v1
Bug:
17988 dynamic-mirror service needs update for image format changes
I would actually completely remove all of the code for the --file-root
option and the property from the manifest; it only existed for use
with the dynamic-mirror service, and a user can just as easily point
at a repository or image now. I would leave all the 'file_root'
properties though in the repository class, etc.
I'm not worried about anyone having used the option successfully since
the dynamic-mirror service has been busted a long time.
However, if you're concerned that change might break more than it's
worth, I could live with that. But at the least, I'd like to see it
removed from the man page and usage.
Ok. I wasn't sure whether it was an option which had a wider base of
use. I'll remove it.
I'm going to assume you tried the dynamic-mirror service and then ran
a pkg install or update with PKG_DUMP_STATS=1 to see if it was
actually using the dynamic mirror or at least configured it.
Yep, configured and used it.
src/depot.py:
line 131: need --image-root here
Ok.
src/modules/server/depot.py:
lines 2209-2210: simplify this to: allowed=["", "<abspathname>"]
I thought I had tried it and it didn't work when image root was /, but
I'll check again and go with what you suggested if possible.
Thanks for taking a look.
Brock
Otherwise, LGTM.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
