On 08/22/11 14:25, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18741-v1
Bug:
18741 variants and facets disagree about what "change" means
imageplan.py:
495 old_facets = self.image.cfg.facets
496 if new_variants or (new_facets != old_facets):
497 self.__varcets_change = True
498 self.__new_variants = new_variants
499 self.__new_facets = new_facets
500 tmp_new_facets = new_facets
501 if tmp_new_facets is None:
502 tmp_new_facets = pkg.facet.Facets()
503 tmp_old_facets = old_facets
504 if tmp_old_facets is None:
505 tmp_old_facets = pkg.facet.Facets()
506 self.__changed_facets = pkg.facet.Facets(dict(
507 set(tmp_new_facets.iteritems()) -
508 set(tmp_old_facets.iteritems())))
509 self.__removed_facets =
set(tmp_old_facets.keys()) - \
510 set(tmp_new_facets.keys())
This code although correct could be shorter and cleaner...
Otherwise, LGTM.
-= Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
