On 08/24/2011 01:47 PM, [email protected] wrote:
I'd appreciate a review of the following webrev
https://cr.opensolaris.org/action/browse/pkg/comay/Build_173_resync/webrev/
which addresses the following issues
18215 Remove print/lp/compatibility/sunos4 package from default
installations
18849 resync repository to snv_173
18850 Java 6 refactoring and versioning needs some work
18851 Update OpenOffice import to account for 3.3.0 changes
Given the large number of package renames in this build, reviewing this
will be tedious. I've attached to 18849 a mapping of the ON renames
that took place
https://defect.opensolaris.org/bz/attachment.cgi?id=4578
and I generated the changes using a sed(1) script and manual
verification.
Mostly it's just a load of "are you sure" type queries.
I suspect it's all just fine.
I gave ...auto-install.p5m a line-by-line check but I admit
I only scanned Redistributable. My eyes were starting to glaze
over.
* src/util/distro-import/172/redist_cluster (line 10)
You removed 'include common/library:openldap' in with a load
of java package removals. Just double checking that that was
intended.
* According to the attachment to bug #18849, both of these map to
the same package.
driver/network/hermon driver/infiniband/connectx
driver/network/mcxe driver/infiniband/connectx
I know that's a valid possibility; I just wanted to make sure it
was correct.
* src/pkg/manifests/group%2fsystem%2fsolaris-auto-install.p5m
I see you are adding 'driver/network/ethernet/sxge' but
'driver/network/sxge' wasn't there before. Just checking
that that's correct.
Similar question for 'system/io/infiniband/udapl' (there now) and
'system/network/udapl' (wasn't there before).
And again for 'system/zones/brand/brand-solaris' (there now) and
'system/zones/brand/solaris' (wasn't there before).
* src/pkg/manifests/group%2fsystem%2fsolaris-large-server.p5m
You are removing '-depend type=group fmri=driver/audio'
but I don't see you adding 'system/io/audio'. Is that correct?
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
