[email protected] wrote:
> https://cr.opensolaris.org/action/browse/pkg/comay/Build_174_Resync/webrev/
importer.py:
- line 1892, 1906, 1907, 1929: no need for backslashes insides parens.
- line 1896, 1911: I don't think you need to put facets on the require
dependencies.
- line 1932: this action has no effect without a version.
*_install.p5m:
- A comment explaining why we need the linted attributes would be nice.
But putting in a summary wouldn't be a bad thing, either, frankly.
developer-gnu.p5m:
- Is it really worth putting gcc-3 in? If so, don't you want
gcc-3-runtime, too?
- You probably want system/library/gcc-45-runtime, as nothing (yet) has a
require dependency on it.
multi-user-desktop.p5m:
- Why are we pulling gnupg, gvim, gedit-plugins out? The latter two got
added to solaris-desktop.
- Why pull out all the python libraries, except for coherence?
solaris-desktop.p5m:
- Why pull out ncftp, system-repo, zones-proxy?
solaris-small-server.p5m:
- Might be more readable if we just had
<transform depend fmri=driver/ -> default variant.opensolaris.zone
global>
Maybe for other parts of the package heirarchy if applicable.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
