On 09/22/11 14:32, Danek Duvall wrote:
This webrev:
https://cr.opensolaris.org/action/browse/pkg/dduvall/alias-move/
fixes
18947 driver alias moving to a brand new driver action causes an error
message about sharing
I'd like to get this in for FCS, as we have one internal customer who is
running into this, and will need to have this functionality fixed before
they can ship their changes.
src/modules/actions/driver.py:
line 230: I'd assign alias to alia_conflict here and then use that
variable on line 239 instead of relying on the last assignment in the
for loop above. That's not technically guaranteed behaviour for the
python interpreter from what I recall.
line 245: Is there a reason this raises RuntimeError instead of
ActionExecutionError?
lines 255-267: Instead of printing, could this import the logger
object and call logger.error() to display these messages? That would
allow the packagemanager to also get them.
Otherwise, LGTM.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
