On 10/21/11 15:03, Danek Duvall wrote:
Turns out that without a fix for
2707 directory salvage doesn't deal with special files well
zone p2v has some issues. Here's a fix that involves taking shutil's
copytree out of the loop:
https://cr.opensolaris.org/action/browse/pkg/dduvall/copytree
I had already looked at this over the weekend, but forgot to reply (doh!).
Do you plan to putback to 2010.2H branch as well as trunk?
src/modules/misc.py:
line 39: we generally put 'from ' imports separate from normal
imports; but that's nitty and i'm not bent over it
lines 112, 158: a brief docstring would be nice (explaining why we
need this)
line 113: Do you want to use PKG_DIR_MODE here to os.makedirs to
ensure creation isn't affected by umask, etc. ?
Otherwise, LGTM.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
