Brock Pytlik wrote:
> https://cr.opensolaris.org/action/browse/pkg/bpytlik/18012-v1
Doesn't this constitute a (compatible) API version change?
image.py:
- line 2432: is a user ever likely to get into a situation where he's
told that a manifest can't be found, and yet he can see it exists? If
so, perhaps the exception raised here should allow the UI to indicate
that the manifest does not properly verify.
tests:
- You could go for more consolidation in the testsuite if pkgsign()
generated sign_args automatically. You repeat what seems to be the
same clause over and over again for generic "please sign this"
functionality.
t_pkg_info.py:
- On a related note, in t_pkg_info.py, you modify the manifest by adding
a license action to it. Why do that instead of signing it? Or adding
a simpler action, like set, that doesn't have a payload?
t_pkg_install.py:
- I'm not understanding how the code in test_bug_18012_keep_installed()
does what the comment says. Or, for that matter, has anything to do
with bug 18012.
t_pkg_verify.py:
- line 185: "runing" -> "running"
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
