Shawn Walker wrote: > On 11/09/11 14:47, Danek Duvall wrote: > >This changeset fixes a few legacy action bugs which have been plaguing > >people for a while: > > > > https://cr.opensolaris.org/action/browse/pkg/dduvall/legacy > > src/modules/actions/legacy.py: > > Instead of: > > 103 + pfile = file(pkginfo, "w") > 104 + for k, v in attrs: > 105 + pfile.write("%s=%s\n" % (k, v)) > 106 + pfile.close() > > I'd suggest: > > with open(pkginfo, "wb") as pfile: > for k, v in attrs: > pfile.write("%s=%s\n" % (k, v))
Thanks. I just kept the code that was there, but this update is fine (and I verified the test suite still passees). Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
