On 01/03/12 23:29, Saurabh Vyas wrote:
On 01/03/12 23:30, Shawn Walker wrote:
On 01/03/12 07:13, Saurabh Vyas wrote:
<< resending this review >>
Hi All,
I fixed this issue on my machine (/etc/hosts ) and had a clean test
run.
Please review this fix :
18958 - Error message concerning /var/pkg/lock & lack of privileges
could be improved
7123469 error handling in __api_plan_exception can be improved
webrev : https://cr.opensolaris.org/action/browse/pkg/saurabhv/18958/
and let me know your comments.
doc/client_api_versions.txt:
line 6: Actually, you named it UnprivilegedUserError, not
ImageLockedError.
src/modules/client/api_errors.py:
line 386: leftover debug line
Thanks Shawn,
I made the necessary changes & rebuild the webrev.
I am facing issue in accessing cr.opensolaris.org so cannot
post the webrev
-----<snip>------
HTTP Status 404 -
type Status report
message
description The requested resource () is not available.
-----------------------------------------------------
Is cr.opensolaris.org down ??
It was, but I notified the admins and they fixed it.
Apart I have created the patch for this issue (attached).
Please let me know if this patch is good to be integrated.
Yes, this looks ready for putback.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
