Brock Pytlik wrote:
> https://cr.opensolaris.org/action/browse/pkg/bpytlik/7129625-v1
manifest.py:
- line 531: "exclduded" -> "excluded"
- line 1098: "factorerd" -> "factored"
- line 1113: "if not excludes"? Why is this clause relevant only if
we're not loading from disk? This means that in order to get a
complete list of actions from a manifest, you'd have to create the
object with its excludes member set to EmptyI, rather than simply
calling this method with excludes=EmptyI. I assume we don't do the
latter anywhere?
- line 1115: Can you explain this? The first test is true if we
triggered the test on 1113, and ended up setting excludes to
self.excludes. So this is effectively saying that either excludes (as
passed into the method) or self.excludes is EmptyI, or they just happen
to be identical, and I don't understand why that would have to be the
case.
t_manifest.py:
- line 395: is this cleaned up automatically?
Sorry if I'm diving too deep, but these changes are not obvious to me.
Perhaps a more detailed evaluation in one of the bugs would help.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
