On 01/20/12 18:28, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19147-v1
Bug:
19147 conflicting action checks can be faster if the image is known to
be good
This is another performance improvement.
Do these changes impact memory usage at all? (Guessing not.)
src/modules/client/image.py:
line 3438: Can you add a comment above this noting what the data
structure is used for and describing the structure of what's stored in it?
line 3482: why no timestamp for this file? if it doesn't need one,
then the comment above is misleading.
line 3485, 3497: cur_key_acts doesn't appear to be used
line 3648: why not return set((l.rstrip() for l in fh)) instead of
return tmp? At the least, s/= /= /. Also, you don't need the
parentheses around the generator inside of set().
src/modules/client/imageplan.py:
lines 1690, 1768: Might want to add a comment stating that .keys() is
used for iteration on the dicts to allow del during iteration.
line 1774: maybe rename this to __check_new_conflicts to make it more
obvious that it's only checking for new action conflicts?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
