On Mon, Jan 23, 2012 at 04:38:38PM -0800, Brock Pytlik wrote: > On 01/23/12 16:24, Edward Pilatowicz wrote: > >On Mon, Jan 23, 2012 at 12:39:26PM -0800, Brock Pytlik wrote: > >>On 01/21/12 00:26, Edward Pilatowicz wrote: > >>>On Fri, Jan 20, 2012 at 07:17:47PM -0800, Brock Pytlik wrote: > >>>>On 01/20/12 15:06, Edward Pilatowicz wrote: > > > >that said, in the interest of making progress, how about i: > > > >- re-introduce it > >- make it optional (and default it to None) during PkgPlan initialization > >- expect callers who initialize a PkgPlan without an image pointer to > > set the image pointer before calling routines which require it. > > > >better? > This sounds reasonable to me. I'd suggest perhaps making "image" a > property of a PkgPlan, rather than a public member, so that it can > be set if it's None, but not if it's anything else, that way a > developer couldn't accidentally change the image that a PkgPlan has > been pointed at (which would likely indicate some kind of bug in > their code). >
cool. i'll code this up and send out and updated webrev. (note that i won't include the setting function now since there are no consumers for it just yet, but it'll be in my other project gate and i'll take your suggestion to only allow it to be set once.) thanks, ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
