On Thu, Feb 23, 2012 at 08:28:20AM -0800, Shawn Walker wrote: > On 02/22/12 18:27, Edward Pilatowicz wrote: > >On Wed, Feb 22, 2012 at 02:04:03PM -0800, Shawn Walker wrote: > >>On 02/21/12 17:46, Edward Pilatowicz wrote: > >>>On Wed, Feb 15, 2012 at 09:04:03AM -0800, Shawn Walker wrote: > >>>>Greetings, > >>>> > >>>>The following webrev contains general changes to improve the overall > >>>>performance of the package system: > >>>> > >>>> 7145683 explore general pkg performance improvements > >>>> > >>>>webrev: > >>>> > >>>> https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-7145863/webrev/ > >>>> > >>>> ...
> >>>---------- > >>>src/modules/actions/generic.py > >>> > >>>- if "hardlinks must follow all filesystem-modifying actions", why are > >>> they followed by "link" actions. > >>> > >>>- user/group actions seem like filesystem modifying actions (since they > >>> update files) so why are they before "dir" actions? (or perhaps i > >>> just don't understand the comment?) > >> > >>For the record; I didn't change the order, but I agree the comment or > >>the order should match the other. > >> > >>The user/group actions must be before dir/file actions so we can > >>chown the file/dir actions to the user/group that we might be > >>delivering at the same time. > >> > >>Since I don't have a deathwish, I'm going to leave the order alone, > >>but here's the new comment: > >> > >># Directories must precede all filesystem object actions; > >># hardlinks must follow all filesystem object actions (except links). > >># Note that usr/group actions precede file actions; this implies that > >># /etc/group and /etc/passwd file ownership needs to be part of initial > >># contents of those files. > >> > > > >assuming i understand this now, could you update this to something like: > > > ># Directories must precede all filesystem object actions; > ># hardlinks must follow all filesystem object actions (except links). > ># Note that usr/group actions precede file actions (so that we know > ># about all the users and groups that other actions may be delivering > ># content for); this implies that /etc/group and /etc/passwd file > ># ownership needs to be part of initial contents of those files. > > It's not so much so that we know about them as that the system > permits them because they're written into the various /etc files > first. We certainly analyse all actions before execution to > determine which users/groups are being delivered during planning > early on. > > I'll assume that's what you meant here... > yeah. that's what i was trying to get at. feel free to rephrase the comment to that end. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
