On 03/ 1/12 04:02 PM, Brock Pytlik wrote:
On 02/29/12 18:49, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/leaping_history/leaping_history-webrev/

Thanks for taking a look,

Only nit I had was that I thought we put the "from ... import ..."s
after the normal imports.

I'll fix that,

I do think this means you'll need to add:
pkg:/library/python-2/lxml-26
to the pkg5 package though.

I'll add that too if nobody objects - the standard xml.etree.ElementTree module thats bundled with Python 2.6 doesn't contain a parser that preserves CDATA sections, which lxml does. Not that it really matters for this test, but all the same, I'd rather be writing a file that looked exactly like the ones we produce.

I'll hold off on a putback till tomorrow in case anyone feels strongly here.

        cheers,
                        tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to