Looks exciting. Just a couple of comments ... > With these changes, older pkg bits reading new config files will fail to > proxy URLs, but will otherwise still function. However, I'm not sure > whether the changes here should really constitute an ImageConfig version > bump, and if so, what the consequences of that are? Perhaps a client API > bump as well?
Older clients would fail on those origins, anyway, right? I don't think there's a compatibility issue sufficient to bump either version. > The intent is to add two new properties, "origin_info" and "mirror_info", > each of which take a list of lists (tuples, maybe?). In each element, we > store the URI, and the proxy used to access that URI. > > So in the pkg5.image config file, this looks something like: > > origins = ['http://foo', 'http://bar', 'http://baz'] > origin_info = [ ['http://foo', 'http://webcache:8080'], > ['http://bar', 'http://www-proxy:80'], > ['http://bar', 'http://www-proxy2:80'], > ['http://baz', 'None'] ] Why a generic name like "info" for something so specific? Either "origin_proxies" (or just "proxies"; why have separate ones for origins and for mirrors?) or make "origin_info" be a dictionary that maps keys (such as "proxies") to lists of tuples pairing URLs with their proxies, which can then later be extended to have other keys (like key/cert like you point out later). > which translates to the the 'pkg publisher' output below: > > timf@kura[36] pkg publisher > PUBLISHER TYPE STATUS URI > foo origin online proxy://http://foo/ > baz origin online http://baz/ > bar origin online proxy://http://bar/ > bar origin online proxy://http://bar/ I'm not thrilled with the proxy:// bit. I kinda see it for the ones which go through the zone proxy, but I don't see why it's necessary here. I find it confusing visually, and I don't believe there's any standard that makes it acceptable for general use. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
