Abhinandan Ekande wrote:
> On 04/07/12 03:14, Shawn Walker wrote:
> >For the record, once you've added a test case, this seems fine to me;
> >we'll have to address the other problems separately.
>
> Thanks Shawn for review.
>
> Here is updated webrev with test case :
> https://cr.opensolaris.org/action/browse/pkg/saurabhv/7140680-rev2/webrev/
t_pkg_history.py:
- Where do we get the localizations for use during the test suite?
/usr/share/locale, or from the gate or proto area somewhere? (Would
this test fail if I didn't have the Chinese locale installed?)
- line 574: no need for the second argument. Though I think I'd rather
see you add support for cmdline_run()'s "env_arg" argument to pkg()
instead of setting the environment globally.
- line 577: no need for "exit=0"; that's the default
Also, please use double quotes instead of single quotes unless there's a
good reason to do otherwise.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
