On 05/ 1/12 10:19 AM, Brock Pytlik wrote:
Anyone feel like taking a look?
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7157272-v2

src/tests/cli/t_pkg_sysrepo.py line 169,

Could you add a small comment saying that self.config consists of a dictionary of config names referencing tuples of (image properties, PC objects)

It might be polite to note in the comment that self.configs is then used to create the images whose configuration is used by pkg.sysrepo to create a corresponding system repository instance? (that's not really this changeset, but could be helpful)

Otherwise, LGTM,

        cheers,
                        tim


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to