On 04/26/12 21:04, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7138994-v1
Bug:
7138994 indexer assertion on set action with 0-length value
Two line change with 100 lines of new tests.
src/modules/indexer.py:
update copyright
line 506: so we really want to assign to old_min_token still?
src/tests/cli/t_pkg_search.py:
lines 905-906: pkgsend_bulk accepts multiple packages, so you can
consolidate these:
self.pkgsend_bulk(rurl, (self.fat_pkg10, self.empty_attr_pkg10))
line 911-912: I assume you're installing these separately in case
there's a failure as the indexing will be easier to debug then
Only other comment I have is does this mean you can't search for
attributes without a value?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
