On 05/07/12 14:38, Shawn Walker wrote:
On 05/07/12 14:32, Brock Pytlik wrote:
On 05/07/12 11:50, Shawn Walker wrote:
On 04/25/12 17:48, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7160289-v1
Bugs:
7160289 pkgrecv failing to pull build s11u1_13: pkgrecv: 'add_file'
failed.
7164129 pkgrecv sets republish goal incorrectly when transferring
packages
This fixes an issue where chain certificate files for signature
actions
weren't always where pkgrecv expected to be if a file for the
signature
payload was present. It also adds checks to the progress checker so
that
when republishing is finished, we make sure we moved the amount of
files
and bytes that we expected to. Had those assertions been there, bug
7164129 wouldn't have happened.
src/modules/client/progress.py:
line 369: I think 'assert_on_mismatch' or 'assert_mismatch' would be
a better parameter than 'merge'. 'merge' seems too specific. May
not matter in the long-run with Dan's upcoming rewhack.
Sure, I can change that.
src/modules/client/transport/transport.py:
line 2313: can you update docstring explaining purpose of in_hash?
Sure.
line 3022: needs wrapping
If you can tell me how to wrap it given that the method name runs past
80 columns, I'm happy to, otherwise I'll leave it as is.
Generally, there's an expectation that if the function name causes it
to go beyond 80 columns, we still wrap the rest of the line. So
something like:
self._progtrack.download_add_progress(
1, int(action.get_chain_csize(c)))
If that's the expectation, then I'll do it.
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
