Hi Shawn,
Thank you for the fix.
The _varcet.c fix LGTM.
Regarding the test script, from the first half of
added part (#182-196), it seems that there's assumption
that nl_ZA is evaluated first.
But in that case, the latter part (from #198) seems to
pass regardless of the _varcet.c fix.
If focuses of the two parts are different and the above
is ok then that's fine. If you want to have the latter
part fail without the _varcet.c fix, changing the
facet configuration with, or adding 3rd part with,
such configuration?
facet.locale.*=none
facet.locale.fr_*=none
facet.locale.fr_CA=none
facet.locale.nl_*=false
facet.locale.nl_ZA=none
Thanks,
Takeshi
On 2012年05月06日 01:48, Shawn Walker wrote:
Greetings,
The webrev below contains fixes for the following issue:
7152124 false wildcard facets can override implicitly or explicitly
set true facets
webrev:
https://cr.opensolaris.org/action/browse/pkg/swalker/7152124-1/webrev/
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
