On 05/25/12 08:45 AM, Brock Pytlik wrote:
Aaah, I'd seen but forgotten that the cache gets deleted by imageplan,
that solves all the issues I was worried about below.

Cool. Thinking about the timeout scenario, I've added a small change: when following redirects, we now set flag to remember whether we timed out while doing so. If the flag was set, then we don't write the cache (to prevent the cache having potentially inaccurate content, which would persist till next publisher change)

If that ultimately results in the system repository having incorrect behaviour, or SMF times us out, the when the service is restarted or moved out of maintenance, if the network is then available and we will be able to write the cache properly.

I wonder if we could detect that we were getting 403's to unconfigured
urls within the apache framework and then use mod_wsgi or something else
to restart our service, which would reduce the issue of a zone being
able to do a DOS attack on the GZ. However, that's clearly outside the
scope of this bug (and probably borders on insanity)

:-)  That's an interesting idea, but yep, not this bug.

so I'm happy with things as they are. It might be worth adding a comment
somewhere in sysrepo.py which explains that the cache gets removed in
> image.save_config.

Good idea, added that. I've just posted the incremental webrev with these changes at:

https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-config-cache-v2

        cheers
                        tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to